Re: [PATCH v2 1/1] leds: syscon: Add tristate option

[Bevan Weiss]

On 19/03/2026 10:33 pm, Bevan Weiss wrote:
> > > +MODULE_LICENSE("GPL");
> >
> > The MODULE_LICENSE() string should match the SPDX identifier at the
> > top of the file.
>
> Sorry, I'm not quite understanding this in the context of other files.
> Most modules within the led subsystem seem to have
> 'GPL-2.0-or-later' as the SPDX identifier, and MODULE_LICENSE("GPL"),
> as I currently have here.
> Is there a different subtlety I'm missing?
> e.g. leds-adp5520.c, leds-as3668.c, leds-blinkm.c
> Perhaps MODULE_LICENSE("GPL v2+")? although I don't see similar
> anywhere in the kernel.
> I'd expect MODULE_LICENSE("GPL v2") to be for 'GPL-2.0-only' licenses.

I've got a v3 mostly ready to send, but was hoping for resolution of the 
MODULE_LICENSE query before submitting.
Can I proceed with MODULE_LICENSE("GPL")?
If not, what value should be here?


Regards,
Bevan Weiss