Re: [PATCH v6 3/4] iio: adc: ad4691: add triggered buffer support
From: David Lechner
Date: Mon Apr 06 2026 - 09:39:36 EST
On 4/6/26 4:22 AM, Sabau, Radu bogdan wrote:
>> -----Original Message-----
>> From: David Lechner <dlechner@xxxxxxxxxxxx>
>> Sent: Saturday, April 4, 2026 6:12 PM
>
> ...
>
>>> +
>>> +/*
>>> + * Valid ACC_DEPTH values where the effective divisor equals the count.
>>> + * From Table 13: ACC_DEPTH = 2^N yields right-shift = N, divisor = 2^N.
>>> + */
>>> +static const int ad4691_oversampling_ratios[] = { 1, 2, 4, 8, 16, 32 };
>>
>> It would be nice to add oversampling in a separate commit as that is a
>> separate feature.
>
> Do you think this would be suitable after the offload commit?
>
Yes, I think that would be OK.