Re: [PATCH v2 2/3] iio: imu: inv_mpu6050: control vdd supply using devm-helpers

[Andy Shevchenko]

On Mon, Apr 06, 2026 at 09:53:14AM +0300, Andrey Skvortsov wrote:
> On 26-04-01 18:10, Andy Shevchenko wrote:
> > On Wed, Apr 01, 2026 at 11:27:36AM +0300, Andrey Skvortsov wrote:

...

> > > -static void inv_mpu_core_disable_regulator_action(void *_data)
> > > +static void inv_mpu_core_disable_regulator_vddio_action(void *_data)
> > 
> > You can rename now _data --> st...
> > 
> > >  {
> > >  	struct inv_mpu6050_state *st = _data;
> > 
> > ...and drop this.
> > 
> > >  	inv_mpu_core_disable_regulator_vddio(st);
> > >  }
> 
> thanks for the review.
> You are right, but this variable will be added in patch 3. Do you
> think it's still worth removing variable here and add it back in patch
> 3? If yes, I'll change it in v2.

Yes, we do not add a dead code. Add it when it's really being used.

-- 
With Best Regards,
Andy Shevchenko