Re: [PATCH v3] staging: media: atomisp: cleanup parenthesis alignment in pci.

From: Andy Shevchenko

Date: Mon Apr 06 2026 - 15:41:41 EST


On Sun, Apr 05, 2026 at 04:39:11PM +0200, Joshua Crofts wrote:
> Cleanup parenthesis alignment as per checkpatch.pl in the
> pci/ directory.

Thanks for doing this. However, the proper fix should be the getting rid of
copy_from_compatible() in favour of using iov_iter. You can consult with
this example:
49aa6ed94c5e ("ALSA: korg1212: Convert to generic PCM copy ops")


The current patch in its form is quite low priority and not guaranteed to be
ever applied. Sorry, we consider real patches to be done first, see above.

(Note, the rest of the patch is okay, but again, quite low priority.)

--
With Best Regards,
Andy Shevchenko