Re: [PATCH v3] dm vdo: use get_random_u32() where appropriate

[Matthew Sakai]

On 4/5/26 11:47 AM, David Carlier wrote:
> Use the typed random integer helpers instead of
> get_random_bytes() when filling a single integer variable.
> The helpers return the value directly, require no pointer
> or size argument, and better express intent.
>
> Signed-off-by: David Carlier <devnexen@xxxxxxxxx>

Reviewed-by: Matthew Sakai <msakai@xxxxxxxxxx>

> ---
>   drivers/md/dm-vdo/indexer/index-layout.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/dm-vdo/indexer/index-layout.c b/drivers/md/dm-vdo/indexer/index-layout.c
> index 61edf2b72427..8707930c9910 100644
> --- a/drivers/md/dm-vdo/indexer/index-layout.c
> +++ b/drivers/md/dm-vdo/indexer/index-layout.c
> @@ -256,7 +256,7 @@ static void create_unique_nonce_data(u8 *buffer)
>   	u32 rand;
>   	size_t offset = 0;
>   
> -	get_random_bytes(&rand, sizeof(u32));
> +	rand = get_random_u32();
>   	memcpy(buffer + offset, &now, sizeof(now));
>   	offset += sizeof(now);
>   	memcpy(buffer + offset, &rand, sizeof(rand));