Re: [PATCH wireless-next 0/6] Consolidate Michael MIC code into mac80211
From: Christoph Hellwig
Date: Tue Apr 07 2026 - 02:37:19 EST
On Tue, Apr 07, 2026 at 08:28:20AM +0200, Johannes Berg wrote:
> On Mon, 2026-04-06 at 23:24 -0700, Christoph Hellwig wrote:
> > On Mon, Apr 06, 2026 at 11:15:08PM -0700, Eric Biggers wrote:
> > > Just to clarify, mac80211 already contains the michael_mic() function.
> > > And every driver that needs Michael MIC already depends on mac80211
> > > except for ipw2x00. So bloat-wise I assumed it's probably better to
> > > make that one driver depend on mac80211, rather than make every driver
> > > pull in the Michael MIC code (by moving it from mac80211 to cfg80211).
> > > But if you prefer that the code be in cfg80211 we can do it that way.
> >
> > To me the most sensible thing would be to have a separate module for
> > the code. If you don't want to expose it too widely for understandable
> > reasons, keep the module in net/wireless/.
> >
> Maybe, but that'd probably be more overhead than anything else? The
> text+data is 725 bytes (on x86-64).
Yeah. Just thinking out loud, if the wireless maintainers are fine with
the cگg80211 version that's probably fine.