Re: [PATCH v2] media: v4l2-core: Removed duplicate lockdep assertion

From: Laurent Pinchart

Date: Tue Apr 07 2026 - 03:47:01 EST


There was a review comment in the previous version of this patch and you
didn't take it into account. Please reply to it and explain why.

On Tue, Apr 07, 2026 at 11:09:46AM +0530, Sunny Patel wrote:
> The __v4l2_subdev_state_get_interval() function has a duplicate
> lockdep_assert_held() call. Removed the redundant assertion.
>
> Signed-off-by: Sunny Patel <nueralspacetech@xxxxxxxxx>
> ---
> drivers/media/v4l2-core/v4l2-subdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
> index 32e6f60e26c7..4616e9280a28 100644
> --- a/drivers/media/v4l2-core/v4l2-subdev.c
> +++ b/drivers/media/v4l2-core/v4l2-subdev.c
> @@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,
> if (WARN_ON(!state))
> return NULL;
>
> - lockdep_assert_held(state->lock);
> -
> if (state->pads) {
> if (stream)
> return NULL;

--
Regards,

Laurent Pinchart