Re: [PATCH] pinctrl: mcp23s08: Disable all pin interrupts during probe

From: Francesco Lavra

Date: Tue Apr 07 2026 - 03:52:53 EST


On Tue, 2026-04-07 at 08:58 +0200, Linus Walleij wrote:
> On Mon, Mar 30, 2026 at 6:19 PM Francesco Lavra <flavra@xxxxxxxxxxxx>
> wrote:
>

....

> > This issue has always been present, but has been latent until commit
> > "f9f4fda15e72" ("pinctrl: mcp23s08: init reg_defaults from HW at probe
> > and
> > switch cache type"), which correctly removed reg_defaults from the
> > regmap
> > and as a side effect changed the behavior of the interrupt handler so
> > that
> > the real value of the MCP_GPINTEN register is now being read from the
> > chip
> > instead of using a bogus 0 default value; a non-zero value for this
> > register can trigger the invocation of a nested handler which may not
> > exist
> > (yet).
> > Fix this issue by disabling all pin interrupts during initialization.
> >
> > Fixes: "f9f4fda15e72" ("pinctrl: mcp23s08: init reg_defaults from HW at
> > probe and switch cache type")

I realized I put stray double quotes around the commit hash.

> > Signed-off-by: Francesco Lavra <flavra@xxxxxxxxxxxx>
>
> Patch applied for fixes since it's pretty urgent, and it also looks
> right to me.
>
> However added some people using this to the CC so they
> get a chance to react before it goes upstream.

Thanks!