Re: [PATCH v6 1/2] docs: s390/pci: Improve and update PCI documentation

From: Niklas Schnelle

Date: Tue Apr 07 2026 - 04:15:49 EST


On Thu, 2026-04-02 at 21:01 -0700, Randy Dunlap wrote:
> Hi,
>
> On 4/2/26 1:34 PM, Niklas Schnelle wrote:
> > Update the s390 specific PCI documentation to better reflect current
> > behavior and terms such as the handling of Isolated VFs via commit
> > 25f39d3dcb48 ("s390/pci: Ignore RID for isolated VFs").
> >
> > Add a descriptions for /sys/firmware/clp/uid_is_unique which was added
> > in commit b043a81ce3ee ("s390/pci: Expose firmware provided UID Checking
> > state in sysfs") but missed documentation.
> >
> > Similarly add documentation for the fidparm attribute added by commit
> > 99ad39306a62 ("s390/pci: Expose FIDPARM attribute in sysfs") and
> > add a list of pft values and their names.
> >
> > Finally improve formatting of the different attribute descriptions by
> > adding a separating colon.
> >
> > Signed-off-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx>
> > ---
> > Documentation/arch/s390/pci.rst | 139 +++++++++++++++++++++++++++-------------
> > 1 file changed, 94 insertions(+), 45 deletions(-)
>
>
> These changes are good, so:
> Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
>
> However, I would go a little farther and add these changes if you
> are OK with them. (Patch applies after both of your patches.)

Thank you for the feedback and the suggestions, I agree with all of
them and they will be part of v7.

Thanks,
Niklas