Re: [net-next PATCH 10/10] net: dsa: tag_rtl8_4: set KEEP flag

[Linus Walleij]

On Wed, Apr 1, 2026 at 1:01 AM Luiz Angelo Daros de Luca
<luizluca@xxxxxxxxx> wrote:

> KEEP=1 is needed because we should respect the format of the packet as
> the kernel sends it to us. Unless tx forward offloading is used, the
> kernel is giving us the packet exactly as it should leave the specified
> port on the wire. Until now this was not needed because the ports were
> always functioning in a standalone mode in a VLAN-unaware way, so the
> switch would not tag or untag frames anyway. But arguably it should have
> been KEEP=1 all along.
>
> Co-developed-by: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>
> Signed-off-by: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@xxxxxxxxx>

Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

I think you could just send this and patch 1 separately so they get
merged first as they are completely self-contained and uncontroversial
and touch the same code.

Yours,
Linus Walleij