Re: [PATCH 3/3] arm64: dts: imx8mp-ab2: Correct interrupt flags

[Shengjiu Wang]

On Mon, Apr 6, 2026 at 2:39 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxxxxxxxx> wrote:
>
> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> These are simple defines so they could be used in DTS but they will not
> have the same meaning:
> 1. GPIO_ACTIVE_HIGH = 0 => IRQ_TYPE_NONE
> 2. GPIO_ACTIVE_LOW  = 1 => IRQ_TYPE_EDGE_RISING
>
> Correct the interrupt flags, assuming the author of the code wanted the
> same logical behavior behind the name "ACTIVE_xxx", this is:
> ACTIVE_LOW  => IRQ_TYPE_LEVEL_LOW
>
> Fixes: bf68c18150ef ("arm64: dts: imx8mp-ab2: add support for NXP i.MX8MP audio board (version 2)")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Thanks for the fix.

Reviewed-by: Shengjiu Wang <shengjiu.wang@xxxxxxx>

Best regards
Shengjiu Wang
> ---
>  arch/arm64/boot/dts/freescale/imx8mp-ab2.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-ab2.dts b/arch/arm64/boot/dts/freescale/imx8mp-ab2.dts
> index dbbc0df0e3d1..443e4fd5b9bf 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-ab2.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-ab2.dts
> @@ -281,7 +281,7 @@ pca9450: pmic@25 {
>                 compatible = "nxp,pca9450c";
>                 reg = <0x25>;
>                 interrupt-parent = <&gpio1>;
> -               interrupts = <3 GPIO_ACTIVE_LOW>;
> +               interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
>                 pinctrl-0 = <&pinctrl_pmic>;
>
>                 regulators {
> --
> 2.51.0
>
>