Re: [patch 10/12] power: supply: charger-manager: Switch to alarmtimer_start()

Next message: Thomas Richter: "[PATCH v3 1/3] perf config: Rename symbol_conf::disable_add2line_warn"
Previous message: Geert Uytterhoeven: "[PATCH] gpio: gpio-by-pinctrl: s/used to do/is used to do/"
In reply to: Thomas Gleixner: "[patch 10/12] power: supply: charger-manager: Switch to alarmtimer_start()"
Next in thread: Thomas Gleixner: "[patch 05/12] posix-timers: Handle the timer_[re]arm() return value"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

From: Peter Zijlstra

Date: Tue Apr 07 2026 - 06:11:27 EST

On Tue, Apr 07, 2026 at 10:55:03AM +0200, Thomas Gleixner wrote:

> + exp = ktime_set(wakeup_ms / MSEC_PER_SEC,
> (wakeup_ms % MSEC_PER_SEC) * NSEC_PER_MSEC);

Surely we can write this less insane?

exp = wakeup_ms * NSEC_PER_MSEC;

comes to mind? And yes, we then seem to loose that KTIME_SEC_MAX check,
but urgh.