Re: [PATCH v1] platform/x86: thinkpad_acpi: Drop ACPI driver registration

From: Ilpo Järvinen

Date: Tue Apr 07 2026 - 06:21:31 EST


On Tue, 24 Mar 2026 21:08:01 +0100, Rafael J. Wysocki wrote:

> There is no point in registering an ACPI driver that only has an empty
> .add() callback, which is done by the thinkpad_acpi driver, since
> after binding to an ACPI device it only sits there and does nothing.
>
> That binding only effectively causes the ACPI device's reference count
> to increase, but that can be achieved by using acpi_get_acpi_dev()
> instead of acpi_fetch_acpi_dev() in setup_acpi_notify(), and doing
> the corresponding cleanup in ibm_exit().
>
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: thinkpad_acpi: Drop ACPI driver registration
commit: 955165c3e537668b9a5a6eb26397281b88143002

--
i.