Re: [PATCH v6 7/7] gpio: gpio-by-pinctrl: add pinctrl based generic GPIO driver

[Geert Uytterhoeven]

Hi Dan,

On Mon, 23 Mar 2026 at 20:04, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> From: AKASHI Takahiro <takahiro.akashi@xxxxxxxxxx>
>
> The ARM SCMI pinctrl protocol allows GPIO access.  Instead of creating
> a new SCMI GPIO driver, this driver is a generic GPIO driver that uses
> standard pinctrl interfaces.
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@xxxxxxxxxx>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>
> Acked-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>

Thanks for your patch, which is now commit 7671f4949a6c9111
("gpio: gpio-by-pinctrl: add pinctrl based generic GPIO driver")
in gpio/for-next.

> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -246,6 +246,19 @@ config GPIO_BRCMSTB
>         help
>           Say yes here to enable GPIO support for Broadcom STB (BCM7XXX) SoCs.
>
> +config GPIO_BY_PINCTRL
> +       tristate "GPIO support based on a pure pin control backend"
> +       depends on GPIOLIB

Should this depend on ARM_SCMI *|| COMPILE_TEST)?  The driver only
matches against the "scmi-pinctrl-gpio" compatible value.
Or do you envision a use case without SCMI?

> +       help
> +         Support for generic GPIO handling based on top of pin control.
> +         Traditionally, firmware creates a GPIO interface or a pin
> +         controller interface and we have a driver to support it.  But
> +         in SCMI, the pin control interface is generic and we can
> +         create a simple GPIO device based on the pin control interface
> +         without doing anything custom.
> +
> +         This driver used to do GPIO over the ARM SCMI protocol.
                        ^
I have sent a patch to add the missing "is".
https://lore.kernel.org/b1ecb31a37f8e35447122554a38985cb6240eb11.1775556619.git.geert+renesas@xxxxxxxxx

> +
>  config GPIO_CADENCE
>         tristate "Cadence GPIO support"
>         depends on OF_GPIO

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds