Re: [PATCH] KVM: selftests: memslot_perf_test: make host wait timeout configurable

[Mayuresh Chitale]

On Tue, Apr 7, 2026 at 4:31 AM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
>
> On Thu, Apr 02, 2026, Mayuresh Chitale wrote:
> > When memslot_perf_test is run on qemu, sometimes the RW subtest fails
>
> For posterity, can you elaborate on exactly what "is run on qemu" means?
Sure.
>
> > @@ -900,7 +901,7 @@ static void help(char *name, struct test_args *targs)
> >  {
> >       int ctr;
> >
> > -     pr_info("usage: %s [-h] [-v] [-d] [-s slots] [-f first_test] [-e last_test] [-l test_length] [-r run_count]\n",
> > +     pr_info("usage: %s [-h] [-v] [-d] [-s slots] [-f first_test] [-e last_test] [-l test_length] [-r run_count] [-a wait_timeout]\n",
> >               name);
> >       pr_info(" -h: print this help screen.\n");
> >       pr_info(" -v: enable verbose mode (not for benchmarking).\n");
> > @@ -916,6 +917,8 @@ static void help(char *name, struct test_args *targs)
> >               targs->seconds);
> >       pr_info(" -r: specify the number of runs per test (currently: %i)\n",
> >               targs->runs);
> > +     pr_info(" -a: specify the number of seconds for host wait timeout (currently: %i)\n",
> > +             wait_timeout);
>
> Why '-a'?  '-t' is available, and seems more intuitive for --timeout.
I was thinking 'a' for 'alarm' but 't' is better :).
>
> >       pr_info("\nAvailable tests:\n");
> >       for (ctr = 0; ctr < NTESTS; ctr++)
> > @@ -964,7 +967,7 @@ static bool parse_args(int argc, char *argv[],
> >       uint32_t max_mem_slots;
> >       int opt;
> >
> > -     while ((opt = getopt(argc, argv, "hvdqs:f:e:l:r:")) != -1) {
> > +     while ((opt = getopt(argc, argv, "hvdqs:f:e:l:r:a:")) != -1) {
> >               switch (opt) {
> >               case 'h':
> >               default:
> > @@ -1007,6 +1010,9 @@ static bool parse_args(int argc, char *argv[],
> >               case 'r':
> >                       targs->runs = atoi_positive("Runs per test", optarg);
> >                       break;
> > +             case 'a':
> > +                     wait_timeout = atoi_positive("Host wait timeout", optarg);
> > +                     break;
> >               }
> >       }
> >
> > --
> > 2.43.0
> >