Re: [PATCH 1/2] arm64: dts: qcom: kodiak: Add iface clock for ice sdhc

[Konrad Dybcio]

On 4/7/26 1:09 PM, Kuldeep Singh wrote:
>>> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi
>>> index dda4697a61b7..5e6b659e8719 100644
>>> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi
>>> @@ -1082,7 +1082,8 @@ sdhc_ice: crypto@7c8000 {
>>>  			compatible = "qcom,sc7280-inline-crypto-engine",
>>>  				     "qcom,inline-crypto-engine";
>>>  			reg = <0x0 0x007c8000 0x0 0x18000>;
>>> -			clocks = <&gcc GCC_SDCC1_ICE_CORE_CLK>;
>>> +			clocks = <&gcc GCC_SDCC1_ICE_CORE_CLK>, <&gcc GCC_SDCC1_AHB_CLK>;
>>> +			clock-names = "core", "iface";
>>
>> nit: one a line would be preferred, please fix that up as you seemingly
>> need a v2 anyway
> 
> Hi Konrad, Didn't get your comment completely.
> 
> Do I need to send v2 to just fix clock entries in 2 lines?
> Or some other comment to address and send v2 for that?
> I don't see any other comment on patchset to address.

I didn't see your reply to Dmitry's initial comment about the DT bindings
requiring an update.

I'd prefer if you sent a v2 with that formatting change. Patches will not be
merged for some ~3 weeks now, due to the kernel release cycle so it'll have
to wait a bit anyway

Konrad