Re: [PATCH 17/53] selftests/mm: uffd-stress: use kselftest framework
From: Mark Brown
Date: Tue Apr 07 2026 - 08:35:29 EST
On Mon, Apr 06, 2026 at 05:16:59PM +0300, Mike Rapoport wrote:
> - printf("bounces: %d, mode:", bounces);
> - if (bounces & BOUNCE_RANDOM)
> - printf(" rnd");
> - if (bounces & BOUNCE_RACINGFAULTS)
> - printf(" racing");
> - if (bounces & BOUNCE_VERIFY)
> - printf(" ver");
> - if (bounces & BOUNCE_POLL)
> - printf(" poll");
> - else
> - printf(" read");
> - printf(", ");
> - fflush(stdout);
> + ksft_print_msg("bounces: %d, mode:%s%s%s%s, ",
> + bounces,
> + bounces & BOUNCE_RANDOM ? " rnd" : "",
> + bounces & BOUNCE_RACINGFAULTS ? " racing" : "",
> + bounces & BOUNCE_VERIFY ? " ver" : "",
> + bounces & BOUNCE_POLL ? " poll" : " read");
This is going to result in the output of a nested line start "# " at
every print, is that desirable? I think it might work out OK given that
there's a stats report each line which will print a newline but the
whole thing is kind of hard to follow. Some comments might help.
Attachment:
signature.asc
Description: PGP signature