Re: [PATCH 3/4] zram: reject unrecognized type= values in recompress_store()
From: Sergey Senozhatsky
Date: Tue Apr 07 2026 - 10:26:09 EST
On (26/04/07 08:38), Andrew Stellman wrote:
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index 8ea2a12..67dea80 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -2555,10 +2555,12 @@ static ssize_t recompress_store(struct device *dev,
> if (!strcmp(param, "type")) {
> if (!strcmp(val, "idle"))
> mode = RECOMPRESS_IDLE;
> - if (!strcmp(val, "huge"))
> + else if (!strcmp(val, "huge"))
> mode = RECOMPRESS_HUGE;
> - if (!strcmp(val, "huge_idle"))
> + else if (!strcmp(val, "huge_idle"))
> mode = RECOMPRESS_IDLE | RECOMPRESS_HUGE;
> + else
> + return -EINVAL;
> continue;
> }
Let's do it like this:
---
@@ -2552,6 +2552,9 @@ static ssize_t recompress_store(struct device *dev,
mode = RECOMPRESS_HUGE;
if (!strcmp(val, "huge_idle"))
mode = RECOMPRESS_IDLE | RECOMPRESS_HUGE;
+
+ if (!mode)
+ return -EINVAL;
continue;
}