[RFC] staging: media: atomisp: change copy_from_compatible to iov_iter

From: Joshua Crofts

Date: Tue Apr 07 2026 - 10:51:36 EST


Hi Andy

I've had some spare time and looked at the copy_from_compatible function
in pci/atomisp_cmd.c. You've recommended checking out the korg1212 driver
and patch for adding iov_iter support. What I find strange is that the korg1212
driver already expects to receive the userspace data in the form of iov_iter,
meanwhile atomisp expects a from and to pointer along with a boolean
whether it's coming from the kernel or userspace. My question is whether
you meant this as a local fix where I'd use an iov_iter in the atomisp_cmd.c
file (maybe separating the functions to user/kernel, since I don't
really like the
passing of the from_user boolean) or if you were hinting to a ground-up
rebuild of the underlying atomisp architecture (which is definitely a tedious
task, looking at the source code).

Thanks for your time.

Kind regards

CJD