Re: [PATCH V1] accel/amdxdna: Handle DETACH_DEBUG_BO through config_debug_bo path

[Lizhi Hou]

On 4/6/26 14:29, Mario Limonciello wrote:
> On 4/6/26 16:14, Lizhi Hou wrote:
> > From: Max Zhen <max.zhen@xxxxxxx>
> >
> > Route DETACH_DEBUG_BO through aie2_config_debug_bo() the same way as
> > ATTACH_DEBUG_BO.
> >
> > The scheduler switch in aie2_sched_job_run() already handles
> > ATTACH_DEBUG_BO with aie2_config_debug_bo(), but DETACH_DEBUG_BO was
> > not included in that path. Add an explicit fallthrough so both attach
> > and detach operations use the same handler.
> >
> > This fixes debug BO detach handling by ensuring the detach command is
> > processed by the expected configuration path.
> >
> > Fixes: 7ea046838021 ("accel/amdxdna: Support firmware debug buffer")
> > Signed-off-by: Max Zhen <max.zhen@xxxxxxx>
> > Signed-off-by: Lizhi Hou <lizhi.hou@xxxxxxx>
> > ---
> >   drivers/accel/amdxdna/aie2_ctx.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/accel/amdxdna/aie2_ctx.c 
> > b/drivers/accel/amdxdna/aie2_ctx.c
> > index 8db32f8e2362..c464cf8024c3 100644
> > --- a/drivers/accel/amdxdna/aie2_ctx.c
> > +++ b/drivers/accel/amdxdna/aie2_ctx.c
> > @@ -360,6 +360,8 @@ aie2_sched_job_run(struct drm_sched_job *sched_job)
> >               ret = aie2_sync_bo(hwctx, job, 
> > aie2_sched_drvcmd_resp_handler);
> >               break;
> >           case ATTACH_DEBUG_BO:
> > +            fallthrough;
> > +        case DETACH_DEBUG_BO:
>
> TBH - I don't think you actually need the fallthrough command here 
> unless you plan to add new code in the ATTACH_DEBUG_BO case.
>
> IE you can do this:
>
> case ATTACH_DEBUG_BO:
> case DETACH_DEBUG_BO:
>
> Reviewed-by: Mario Limonciello (AMD) <superm1@xxxxxxxxxx>

Thanks. Applied to drm-misc-next.

Lizhi

> >               ret = aie2_config_debug_bo(hwctx, job, 
> > aie2_sched_drvcmd_resp_handler);
> >               break;
> >           default: