Re: [PATCH] mm/mempolicy: Fix weighted interleave auto sysfs name
From: Gregory Price
Date: Tue Apr 07 2026 - 13:37:55 EST
On Tue, Apr 07, 2026 at 10:23:50AM -0700, Joshua Hahn wrote:
> On Tue, 7 Apr 2026 13:09:04 -0400 Gregory Price <gourry@xxxxxxxxxx> wrote:
>
> > > Signed-off-by: Joshua Hahn <joshua.hahnjy@xxxxxxxxx>
> >
> > Maybe -
> >
> > Fixes: 2fb6915fa22d ("compiler_types.h: add "auto" as a macro for "__auto_type"")
>
> I thought about adding a Fixes tag, decided against it because it's
> purely cosmetic.
>
> ... but now that I think about it, I think this could break some workflows
> for users who have automated writing to the auto sysfs file.
>
Yes, it broke userland software depending on that symbol being there
(which, hopefully, is very little at this point in time).
> Maybe I should add a fixes tag for the patch that introduced the
> sysfs file instead? That is,
>
> Fixes: e341f9c3c841 ("mm/mempolicy: Weighted Interleave Auto-tuning")
>
The original commit introduced 'auto' and the compiler_types.h commit
modified that to "__auto_type". The latter broke userland so that's the
right commit to mark for Fixes.
~Gregory