Re: [PATCH 07/19] drm/panel: himax-hx83102: support Waveshare 12.3" DSI panel

[Linus Walleij]

Hi Dmitry,

thanks for your patch!

On Wed, Apr 1, 2026 at 9:26 AM Dmitry Baryshkov
<dmitry.baryshkov@xxxxxxxxxxxxxxxx> wrote:

> Add support for the Waveshare 12.3" DSI TOUCH-A panel. According to the
> vendor driver, it uses different mode_flags, so let the panel
> descriptions override driver-wide defaults.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
(...)
> +#define HX83102_UNKNOWN_BB     0xbb
(...)
> +#define HX83102_UNKNOWN_C2     0xc2
> +#define HX83102_UNKNOWN_C6     0xc6

What I am unable to fathom is why Qualcomm, a fortune 500 company, would be
unable to muscle out the datasheet for this display controller from
the panel vendor
and provide some proper names for these defines.

Could you try to ask Waveshare to just share the datasheet so you can say
what is going on here.

If we have too many *UNKNOWN_NN" it will get hard to see of the same code
can be introduced and refactored into other inits without risk of breaking
something is my thinking here.

If it's like ... really hard for you to achieve this I guess I will
grumpily accept it
but it'd be nice if you try sending the message that we want to know what these
things are.

Yours,
Linus Walleij