Re: [PATCH] mm: move folio LRU helpers out of swap

From: Barry Song

Date: Tue Apr 07 2026 - 22:28:21 EST


On Wed, Apr 8, 2026 at 8:41 AM Jianyue Wu <wujianyue000@xxxxxxxxx> wrote:
>
> On 4/7/2026 10:22 PM, Johannes Weiner wrote:
> > Ironically, the only thing that doesn't fit in this file is the swap
> > stuff. The page_cluster & sysctl should be static in swap_state.c.
> >
> > The rest seems thematically relatively clean - infrastructure for
> > managing folio lifetime. swap.c is not the best name for it, but short
> > of finding a very clear improvement I'd just leave it alone.
>
> Thanks everyone for the reviews and the clear feedback.
>
> I’m withdrawing this patch. I understand the concerns about the
> relative include path, the limited benefit versus churn/conflicts.
> I learned a lot from the discussion, many details in mm parts.

Please don’t abandon this direction — it just needs a better
approach. While this patch isn’t perfect, cleaning up
include/linux/swap.h and mm/swap.c seems like a worthwhile
path. include/linux/swap.h is basically a tangled mess.

Thanks
Barry