Re: [PATCH v2 5/8] x86/microcode/hygon: Add microcode loading support for Hygon processors

From: Fu Hao

Date: Tue Apr 07 2026 - 22:57:02 EST


On 2026/4/7 22:11, Borislav Petkov wrote:
On Tue, Apr 07, 2026 at 07:00:39AM -0700, Dave Hansen wrote:
On 4/7/26 01:24, Fu Hao wrote:
...
arch/x86/kernel/cpu/microcode/hygon.c | 927 +++++++++++++++++++++++
This looks a lot like:

cat amd.c | perl -pe 's/amd/hygon/' > hygon.c

If it's something like that, I think it probably needs to get mentioned
up front and discussed about what's actually *different* from the AMD
implementation.

Yes, and there's a *lot* of AMD-specific stuff in there.

I'd suggest you go through the code with a fine-toothed comb and remove
everything you won't need and you don't use.

Thx.


Thank you for the clear guidance. We will rethink the code structure
and specific implementation, and only retain the minimum necessary to
maintain the basic functionality.

--
Regards,
Fu Hao