Re: [PATCH v9 19/31] gpu: nova-core: Hopper/Blackwell: add FSP secure boot completion waiting

[John Hubbard]

On 4/7/26 6:52 PM, Alexandre Courbot wrote:
> On Thu Mar 26, 2026 at 10:38 AM JST, John Hubbard wrote:
>> Add the FSP (Firmware System Processor) module for Hopper/Blackwell GPUs.
>> These architectures use a simplified firmware boot sequence:
>>
>>     FMC --> FSP --> GSP, with no SEC2 involvement.
>>
>> This commit adds the ability to wait for FSP secure boot completion by
>> polling the I2CS thermal scratch register until FSP signals success.
> 
> This does more than just the boot completion waiting (which is just the
> `wait_secure_boot` method) - it looks like most of the content of
> `fsp.rs` should be moved to different patches.

"I" will do that, no problem. Especially no problem since you
already did it for me in a branch. :)  Thanks!

...
>> +
>> +/// FSP secure boot completion timeout in milliseconds.
>> +///
>> +/// GB20x requires a longer timeout than Hopper/GB10x.
>> +const fn fsp_secure_boot_timeout_ms(arch: crate::gpu::Architecture) -> i64 {
>> +    match arch {
>> +        crate::gpu::Architecture::BlackwellGB20x => 5000,
>> +        _ => 4000,
>> +    }
>> +}
> 
> Since this is a timeout, how about harmonizing to 5000 for everyone and
> turning this into a constant? Waiting 1 more second in case of a boot
> failure should be acceptable. :)
> 

Yes, will do.

thanks,
-- 
John Hubbard