Re: [PATCH v2] gpu: nova: require little endian

[Eliot Courtney]

On Tue Apr 7, 2026 at 11:22 PM JST, Danilo Krummrich wrote:
> On Tue Apr 7, 2026 at 5:59 AM CEST, Eliot Courtney wrote:
>> The driver already assumes little endian in a lot of locations. For
>> example, all the code that reads RPCs out of the command queue just
>> directly interprets the bytes.
>>
>> Make this explicit in Kconfig.
>>
>> Signed-off-by: Eliot Courtney <ecourtney@xxxxxxxxxx>
>> ---
>> The current code assumes little endian in a bunch of places. I think we
>> should either explicitly decide to be generic on endianness or explicitly
>> decide not to - having some handling sprinkled around in various
>> locations seems confusing to me.
>>
>> I believe that currently e.g. `RUST` transitively depends on
>> !CPU_BIG_ENDIAN, so this is more about making the decision explicit for
>> nova-core rather than fixing any kind of hole.
>> ---
>> Changes in v2:
>> - Also add to nova-drm (Thanks Danilo)
>> - Did not take Reviewed-by + Acked-by because commit changed
>>   substantively
>> - Link to v1: https://patch.msgid.link/20260406-fix-kconfig-v1-1-8f634499f7f0@xxxxxxxxxx
>
> Thanks for the new version -- I have one additional question in [1]. Otherwise,
> going to pick up once -rc1 is out.
>
> [1] https://lore.kernel.org/all/DHMVA3S2MZWV.1JN7WUBZLRWLV@xxxxxxxxxx/

Thanks. I think others have answered the question (Thanks Timur and Joel)
so hopefully all good.