Re: [PATCH v2 2/2] arm64: dts: qcom: milos: Add IMEM node

[Luca Weiss]

Hi Krzysztof,

On Wed Apr 8, 2026 at 9:34 AM CEST, Krzysztof Kozlowski wrote:
> On Tue, Apr 07, 2026 at 05:11:11PM +0200, Luca Weiss wrote:
>> Add a node for the IMEM found on Milos, which contains pil-reloc-info
>> and the modem tables for IPA, among others.
>> 
>> Signed-off-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
>> ---
>> Not happy about the names of the subnodes. pil-reloc-sram is not allowed
>> it seems. Glymur calls it "pil-sram@94c", not sure this is wanted?
>> 
>> Please advice.
>> ---
>>  arch/arm64/boot/dts/qcom/milos.dtsi | 20 ++++++++++++++++++++
>>  1 file changed, 20 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom/milos.dtsi
>> index 4a64a98a434b..0c69d5810f5e 100644
>> --- a/arch/arm64/boot/dts/qcom/milos.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/milos.dtsi
>> @@ -2289,6 +2289,26 @@ scl-pins {
>>  			};
>>  		};
>>  
>> +		sram@14680000 {
>> +			compatible = "qcom,milos-imem", "mmio-sram";
>> +			reg = <0x0 0x14680000 0x0 0x2c000>;
>> +			ranges = <0 0 0x14680000 0x2c000>;
>
> Use hex here as well.

Will do: ranges = <0x0 0x0 0x14680000 0x2c000>;

Do you also have a comment around the name of the subnodes? Do you think
they're okay as-is, or should they be changed?

Regards
Luca