Re: [PATCH] Bluetooth: SCO: check for codecs->num_codecs == 1 before assigning to sco_pi(sk)->codec

[Stefan Metzmacher]

Hi Luiz,

> > > I guess this is odd because there was no need for this code to exist,
> > > BT_CODEC should have used struct bt_codec rather than struct bt_codecs
> > > since we can only set exactly one codec, that said I don't think we
> > > can change this now thus why we need to perform these checks, anyway
> > > back to your changes why don't we have both checks for num_codecs != 1
> > > && optlen < struct_size(codecs, codecs, codecs->num_codecs)) since the
> > > handling is the same?
> >
> > Should I submit a v2 using this:
> > if (codecs->num_codecs != 1 || optlen < struct_size(codecs, codecs, codecs->num_codecs))
> >
> > Or can you to take it from here?
> > As I don't really care and the patch is not strictly needed.
>
> I can fix it myself, no problem.

Great! Thanks!
metze