Re: [PATCH] ASoC: nau8325: Add software reset during probe
From: YLCHANG2
Date: Wed Apr 08 2026 - 04:56:28 EST
On 4/8/26 16:07, Cezary Rojewski wrote:
On 2026-04-08 7:26 AM, Neo Chang wrote:
Currently, the driver only performs a hardware reset during the I2C probe
sequence. To ensure all internal states of the codec are properly cleared
without affecting the configuration registers, a software reset is also
required.
According to the hardware specification, writing to the Software Reset
register (R01) twice will reset all internal states safely.
This patch adds the nau8325_software_reset() function, executes it right
after the hardware reset in the probe function, and marks the R01 register
as writeable in the regmap configuration.
The first two paragraphs explain the situation, I'd say the third is redundant. Not a reason for a resend though, only something to consider.
Reviewed-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
Thank you for the review and the advice on the commit message.
I will keep it in mind for the next time.