Re: [PATCH 1/2] dt-bindings: fpga: add binding for Technologic Systems TS-73xx FPGA

[Krzysztof Kozlowski]

On Tue, Apr 07, 2026 at 06:27:29PM +0100, Phil Pemberton wrote:
> Add device tree binding documentation for the Altera Cyclone II FPGA
> found on Technologic Systems TS-7300 series boards, programmed via a
> CPLD memory-mapped interface.

A nit, subject: drop second/last, redundant "binding for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

> 
> Signed-off-by: Phil Pemberton <philpem@xxxxxxxxxxxxx>
> ---
>  .../fpga/technologic,ts73xx-fpga.yaml         | 42 +++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/fpga/technologic,ts73xx-fpga.yaml
> 
> diff --git a/Documentation/devicetree/bindings/fpga/technologic,ts73xx-fpga.yaml b/Documentation/devicetree/bindings/fpga/technologic,ts73xx-fpga.yaml
> new file mode 100644
> index 000000000000..1f7a651e8f10
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fpga/technologic,ts73xx-fpga.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/fpga/technologic,ts73xx-fpga.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Technologic Systems TS-73xx FPGA Manager
> +
> +maintainers:
> +  - Florian Fainelli <f.fainelli@xxxxxxxxx>
> +
> +description:
> +  FPGA manager for the Altera Cyclone II FPGA on Technologic Systems
> +  TS-7300 series boards. The FPGA is programmed via a CPLD interface
> +  at a memory-mapped register pair.
> +
> +properties:
> +  compatible:
> +    const: technologic,ts73xx-fpga

So xx is a wildcard? That's not allowed (see writing bindings or any
talks). You need specific compatible. And compatibility, so fallbacks,
if you have multiple distinctive devices.

> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    bus {
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        ranges;

Drop entire node, not needed.

Best regards,
Krzysztof