[PATCH v4 2/6] staging: rtl8723bs: make rtw_alloc_hwxmits static
From: Hungyu Lin
Date: Wed Apr 08 2026 - 06:46:31 EST
The rtw_alloc_hwxmits() function is only used within this file.
Make it static to limit its scope.
Signed-off-by: Hungyu Lin <dennylin0707@xxxxxxxxx>
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 80 ++++++++++----------
drivers/staging/rtl8723bs/include/rtw_xmit.h | 1 -
2 files changed, 40 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index f64ec8e271ed..b86c9c2f3b93 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -33,6 +33,46 @@ void _rtw_init_sta_xmit_priv(struct sta_xmit_priv *psta_xmitpriv)
INIT_LIST_HEAD(&psta_xmitpriv->apsd);
}
+static s32 rtw_alloc_hwxmits(struct adapter *padapter)
+{
+ struct hw_xmit *hwxmits;
+ struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
+
+ pxmitpriv->hwxmit_entry = HWXMIT_ENTRY;
+
+ pxmitpriv->hwxmits = NULL;
+
+ pxmitpriv->hwxmits = kzalloc_objs(*hwxmits, pxmitpriv->hwxmit_entry,
+ GFP_ATOMIC);
+ if (!pxmitpriv->hwxmits)
+ return _FAIL;
+
+ hwxmits = pxmitpriv->hwxmits;
+
+ if (pxmitpriv->hwxmit_entry == 5) {
+ hwxmits[0] .sta_queue = &pxmitpriv->bm_pending;
+
+ hwxmits[1] .sta_queue = &pxmitpriv->vo_pending;
+
+ hwxmits[2] .sta_queue = &pxmitpriv->vi_pending;
+
+ hwxmits[3] .sta_queue = &pxmitpriv->bk_pending;
+
+ hwxmits[4] .sta_queue = &pxmitpriv->be_pending;
+ } else if (pxmitpriv->hwxmit_entry == 4) {
+ hwxmits[0] .sta_queue = &pxmitpriv->vo_pending;
+
+ hwxmits[1] .sta_queue = &pxmitpriv->vi_pending;
+
+ hwxmits[2] .sta_queue = &pxmitpriv->be_pending;
+
+ hwxmits[3] .sta_queue = &pxmitpriv->bk_pending;
+ } else {
+ }
+
+ return _SUCCESS;
+}
+
s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter)
{
int i;
@@ -1852,46 +1892,6 @@ s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame *pxmitframe)
return res;
}
-s32 rtw_alloc_hwxmits(struct adapter *padapter)
-{
- struct hw_xmit *hwxmits;
- struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
-
- pxmitpriv->hwxmit_entry = HWXMIT_ENTRY;
-
- pxmitpriv->hwxmits = NULL;
-
- pxmitpriv->hwxmits = kzalloc_objs(*hwxmits, pxmitpriv->hwxmit_entry,
- GFP_ATOMIC);
- if (!pxmitpriv->hwxmits)
- return _FAIL;
-
- hwxmits = pxmitpriv->hwxmits;
-
- if (pxmitpriv->hwxmit_entry == 5) {
- hwxmits[0] .sta_queue = &pxmitpriv->bm_pending;
-
- hwxmits[1] .sta_queue = &pxmitpriv->vo_pending;
-
- hwxmits[2] .sta_queue = &pxmitpriv->vi_pending;
-
- hwxmits[3] .sta_queue = &pxmitpriv->bk_pending;
-
- hwxmits[4] .sta_queue = &pxmitpriv->be_pending;
- } else if (pxmitpriv->hwxmit_entry == 4) {
- hwxmits[0] .sta_queue = &pxmitpriv->vo_pending;
-
- hwxmits[1] .sta_queue = &pxmitpriv->vi_pending;
-
- hwxmits[2] .sta_queue = &pxmitpriv->be_pending;
-
- hwxmits[3] .sta_queue = &pxmitpriv->bk_pending;
- } else {
- }
-
- return _SUCCESS;
-}
-
void rtw_free_hwxmits(struct adapter *padapter)
{
struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
diff --git a/drivers/staging/rtl8723bs/include/rtw_xmit.h b/drivers/staging/rtl8723bs/include/rtw_xmit.h
index 544468f57692..b0189a703d28 100644
--- a/drivers/staging/rtl8723bs/include/rtw_xmit.h
+++ b/drivers/staging/rtl8723bs/include/rtw_xmit.h
@@ -457,7 +457,6 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter);
void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv);
-s32 rtw_alloc_hwxmits(struct adapter *padapter);
void rtw_free_hwxmits(struct adapter *padapter);
--
2.34.1