Re: [PATCH net v4 15/15] rxrpc: fix reference count leak in rxrpc_server_keyring()

From: David Howells

Date: Wed Apr 08 2026 - 06:56:53 EST


David Howells <dhowells@xxxxxxxxxx> wrote:

> Anderson Nascimento <anderson@xxxxxxxxxxxxxxxxxx> wrote:
>
> > Isn't this the same issue addressed by my patch "[PATCH net v4 08/15]
> > rxrpc: Fix keyring reference count leak in rxrpc_setsockopt()"? Just
> > asking to make sure this is intended.
>
> Actually, I think it's probably better to use Luxiao Xu's patch rather than
> yours as it puts the check down into the function that actually makes the
> change.

I also then need to remove the rx->key check.

David