Re: [PATCH v2 01/11] dt-bindings: regulator: ti,pbias-regulator: Convert to DT schema

[Rob Herring]

On Wed, Apr 08, 2026 at 09:57:20AM +0200, Thomas Richard wrote:
> Hello Krzysztof,
> 
> On 3/31/26 10:21 AM, Krzysztof Kozlowski wrote:
> > On Mon, Mar 30, 2026 at 03:43:58PM +0200, Thomas Richard wrote:
> >> +$id: http://devicetree.org/schemas/regulator/ti,pbias-regulator.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: PBIAS internal regulator
> >> +
> >> +maintainers:
> >> +  - Thomas Richard <thomas.richard@xxxxxxxxxxx>
> >> +
> >> +description: |
> > 
> > Do not need '|' unless you need to preserve formatting.
> > 
> >> +  PBIAS internal regulator for SD card dual voltage i/o pads on OMAP SoCs.
> >> +
> >> +properties:
> >> +  compatible:
> >> +    items:
> >> +      - enum:
> >> +          - ti,pbias-dra7
> >> +          - ti,pbias-omap2
> >> +          - ti,pbias-omap3
> >> +          - ti,pbias-omap4
> >> +          - ti,pbias-omap5
> >> +      - const: ti,pbias-omap
> >> +
> >> +  reg:
> >> +    maxItems: 1
> >> +
> >> +  syscon:
> >> +    description: Phandle of the system control module
> >> +    $ref: /schemas/types.yaml#/definitions/phandle
> >> +
> >> +patternProperties:
> >> +  '^pbias_*':
> > 
> > That wasn't in old binding and underscore is not allowed, so this needs
> > explanation. Old binding mentioned only the names.
> 
> I did it to match existing devicetrees.
> I guess I should define properties like 'pbias-mmc' and 'pbias-sim',
> then update node names in devicetrees to match binding.

For this ancient stuff, I would just leave the dts files alone. Just 
explain that in the commit message.

Your pattern should be '^pbias_' though.

Rob