Re: [PATCH] regulator: bq257xx: drop confusing configuration of_node

[Mark Brown]

On Wed, Apr 08, 2026 at 02:53:47PM +0200, Johan Hovold wrote:
> The driver reuses the OF node of the parent multi-function device but
> still sets the of_node field of the regulator configuration to any prior
> OF node.

Copying in Chris.

> Since the MFD child device does not have an OF node set until probe is
> called, this field is set to NULL on first probe and to the reused OF
> node if the driver is later rebound.
> 
> As the device_set_of_node_from_dev() helper drops a reference to any
> prior OF node before taking a reference to the new one this can
> apparently also confuse LLMs like Sashiko which flags it as a potential
> use-after-free (which it is not).
> 
> Drop the confusing and redundant configuration of_node assignment.
> 
> Link: https://sashiko.dev/#/patchset/20260408073055.5183-1-johan%40kernel.org
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> ---
> 
> This is a follow-up to the reused OF node imbalance series:
> 
> 	https://lore.kernel.org/lkml/20260408073055.5183-1-johan@xxxxxxxxxx/
> 
> to address a false-positive Sashiko report.
> 
> Johan
> 
> 
>  drivers/regulator/bq257xx-regulator.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/regulator/bq257xx-regulator.c b/drivers/regulator/bq257xx-regulator.c
> index 711dbe045383..86225566e10a 100644
> --- a/drivers/regulator/bq257xx-regulator.c
> +++ b/drivers/regulator/bq257xx-regulator.c
> @@ -139,7 +139,6 @@ static int bq257xx_regulator_probe(struct platform_device *pdev)
>  	struct device *dev = &pdev->dev;
>  	struct bq257xx_device *bq = dev_get_drvdata(pdev->dev.parent);
>  	struct bq257xx_reg_data *pdata;
> -	struct device_node *np = dev->of_node;
>  	struct regulator_config cfg = {};
>  
>  	device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent);
> @@ -156,7 +155,6 @@ static int bq257xx_regulator_probe(struct platform_device *pdev)
>  
>  	cfg.dev = &pdev->dev;
>  	cfg.driver_data = pdata;
> -	cfg.of_node = np;
>  	cfg.regmap = dev_get_regmap(pdev->dev.parent, NULL);
>  	if (!cfg.regmap)
>  		return -ENODEV;
> -- 
> 2.52.0
>

Attachment: signature.asc
Description: PGP signature