Re: [PATCH] lib/vsprintf: use bool for local decode variable

[Andy Shevchenko]

On Wed, Apr 08, 2026 at 09:53:35AM +0200, Petr Mladek wrote:
> On Tue 2026-04-07 20:18:36, Thorsten Blum wrote:

...

> I have mixed feeling about this patch

Same here.

> I agree that it might slightly
> improve code readability. But cosmetic changes are usually about
> personal preferences and often just pollute code history.
> 
> IMHO, this is really just about "code readability" vs "code history
> pollution" problem. I believe that compilers would handle both variants
> the same way.
> 
> As I said, I agree that this this slightly improves the code
> readability and it is trivial. So I am going to wait few more
> days and take this patch unless there is a strong push back
> from others.

Up to you, no pushback from me, and no tag as well. Personally
I consider it's a churn, but we have tons of a such in the kernel
(I mean int as boolean cases).

-- 
With Best Regards,
Andy Shevchenko