Re: [PATCH net-next] net: phy: fix a return path in get_phy_c45_ids()

[Andrew Lunn]

On Wed, Apr 08, 2026 at 06:31:44AM -0700, Charles Perry wrote:
> The return value of phy_c45_probe_present() is store in "ret", not
> "phy_reg", fix this. "phy_reg" always has a positive value if we reach
> this return path (since it would have returned earlier otherwise), which
> means that the original goal of the patch of not considering -ENODEV
> fatal wasn't achieved.
> 
> Fixes: 17b447539408 ("net: phy: c45 scanning: Don't consider -ENODEV fatal")
> Signed-off-by: Charles Perry <charles.perry@xxxxxxxxxxxxx>

Thanks for fixing this.

The Subject line should be [PATCH net] since this is a Fix.

Otherwise:

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew