Re: [PATCH v2 2/2] crypto/ccp: Skip SNP_INIT if preparation fails

[Tycho Andersen]

On Wed, Apr 08, 2026 at 08:17:44AM -0500, Tom Lendacky wrote:
> On 4/7/26 12:47, Tycho Andersen wrote:
> > From: "Tycho Andersen (AMD)" <tycho@xxxxxxxxxx>
> > 
> > During SNP_INIT, the firmware checks to see that the SNP enable bit is set
> > on all CPUs. If snp_prepare() failed because not all CPUs were online,
> > SNP_INIT will fail, so skip it.
> 
> This should probably be more generic and state that if snp_prepare()
> fails for any reason then SNP_INIT will fail, so skip it.

Yep, thanks. I can send a v3 with all of these fixes.

And to preempt questions about sashiko:
https://sashiko.dev/#/patchset/20260407174713.439474-1-tycho%40kernel.org

The first one is bogus, but I also got it from AI when reviewing this
series: the previous code returned the error from the firmware as well
and killed initialization completely.

The other two are ones that were previously reported, I have fixes for
them but have not yet posted...

Tycho