Re: [RFC] media: atomisp: change copy_from_compatible to iov_iter
From: Joshua Crofts
Date: Wed Apr 08 2026 - 10:45:12 EST
On Wed, 8 Apr 2026 at 16:29, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
>
> > It doesn't change any architectural decision here. Basically you need to have
> > s3a_output_bytes to be already iov_iter at this point. So, import_ubuf() has to
> > happen somewhere else.
Yes, I know it's not an architectural change, more of a temporary
band-aid for better pointer
management, but fair, pointless for now.
> which suggests that iov_iter should be somewhere here, in the struct
> atomisp_subdev_params. But you need to read much more code and get familiar
> with this. I wouldn't expect any meaningful change by a few days, maybe by
> a few weeks as this driver is quite complicated.
I agree, the codebase is complicated, I definitely won't send any
changes at the moment
(unless they would be checkpatch.pl changes, which are low priority
ofc). However, the
iov_iter problem is intriguing and I'll surely spend some time working on it.
> In any case, thanks into trying with this, will be very appreciated
> when the task is logically finished.
Not promising anything. Thanks for your response!
--
Kind regards
CJD