Re: [PATCH 3/3] staging: rtl8723bs: remove unnecessary blank lines in rtl8723b_phycfg.c

[Luka Gejak]

On Wed Apr 8, 2026 at 12:32 PM CEST, osjin83 wrote:
> From: tas0dev <osjin83@xxxxxxxxx>
>
> Remove unnecessary blank lines throughout rtl8723b_phycfg.c to clean
> up the code and adhere to the Linux kernel coding style.
>
> Signed-off-by: tas0dev <osjin83@xxxxxxxxx>
Your Signed-off-by tag must use you real name(First Last) to comply 
with the Developers Certificate of Origin. You should also use your
real name for sending emails.
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 14 --------------
>  1 file changed, 14 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> index 498f7b25a2b5..10eb96105f83 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> @@ -25,7 +25,6 @@ static	u32 phy_CalculateBitShift(u32 BitMask)
>  	return i;
>  }
>  
> -
>  /**
>   * PHY_QueryBBReg_8723B - Read "specific bits" from BB register.
>   * @Adapter:
> @@ -46,10 +45,8 @@ u32 PHY_QueryBBReg_8723B(struct adapter *Adapter, u32 RegAddr, u32 BitMask)
>  	BitShift = phy_CalculateBitShift(BitMask);
>  
>  	return (OriginalValue & BitMask) >> BitShift;
> -
>  }
>  
> -
>  /**
>   * PHY_SetBBReg_8723B - Write "Specific bits" to BB register (page 8~).
>   * @Adapter:
> @@ -80,10 +77,8 @@ void PHY_SetBBReg_8723B(
>  	}
>  
>  	rtw_write32(Adapter, RegAddr, Data);
> -
>  }
>  
> -
>  /*  */
>  /*  2. RF register R/W API */
>  /*  */
> @@ -141,7 +136,6 @@ static u32 phy_RFSerialRead_8723B(
>  		retValue = PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBack | MaskforPhySet, bLSSIReadBackData);
>  	}
>  	return retValue;
> -
>  }
>  
>  /**
> @@ -210,7 +204,6 @@ static void phy_RFSerialWrite_8723B(
>  	PHY_SetBBReg(Adapter, pPhyReg->rf3wireOffset, bMaskDWord, DataAndAddr);
>  }
>  
> -
>  /**
>   * PHY_QueryRFReg_8723B - Query "Specific bits" to RF register (page 8~).
>   * @Adapter:
> @@ -272,12 +265,10 @@ void PHY_SetRFReg_8723B(
>  	phy_RFSerialWrite_8723B(Adapter, eRFPath, RegAddr, Data);
>  }
>  
> -
>  /*  */
>  /*  3. Initial MAC/BB/RF config by reading MAC/BB/RF txt. */
>  /*  */
>  
> -
>  /*-----------------------------------------------------------------------------
>   * PHY_MACConfig8192C - Config MAC by header file or parameter file.
>   *
> @@ -329,7 +320,6 @@ static void phy_InitBBRFRegisterDefinition(struct adapter *Adapter)
>  	pHalData->PHYRegDef[RF_PATH_B].rfLSSIReadBack = rFPGA0_XB_LSSIReadBack;
>  	pHalData->PHYRegDef[RF_PATH_A].rfLSSIReadBackPi = TransceiverA_HSPI_Readback;
>  	pHalData->PHYRegDef[RF_PATH_B].rfLSSIReadBackPi = TransceiverB_HSPI_Readback;
> -
>  }
>  
>  static int phy_BB8723b_Config_ParaFile(struct adapter *Adapter)
> @@ -373,7 +363,6 @@ static int phy_BB8723b_Config_ParaFile(struct adapter *Adapter)
>  	return _SUCCESS;
>  }
>  
> -
>  int PHY_BBConfig8723B(struct adapter *Adapter)
>  {
>  	int	rtStatus = _SUCCESS;
> @@ -614,7 +603,6 @@ static void phy_PostSetBwMode8723B(struct adapter *Adapter)
>  	u8 SubChnlNum = 0;
>  	struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
>  
> -
>  	/* 3 Set Reg668 Reg440 BW */
>  	phy_SetRegBW_8723B(Adapter, pHalData->CurrentChannelBW);
>  
> @@ -725,13 +713,11 @@ static void PHY_HandleSwChnlAndSetBW8723B(
>  	if (!pHalData->bSetChnlBW && !pHalData->bSwChnl)
>  		return;
>  
> -
>  	if (pHalData->bSwChnl) {
>  		pHalData->CurrentChannel = ChannelNum;
>  		pHalData->CurrentCenterFrequencyIndex1 = ChannelNum;
>  	}
>  
> -
>  	if (pHalData->bSetChnlBW) {
>  		pHalData->CurrentChannelBW = ChnlWidth;
>  		pHalData->nCur40MhzPrimeSC = ExtChnlOffsetOf40MHz;