Re: [PATCH] xfs: check da node block pad field during scrub

[Yuto Ohnuki]

On Mon, Apr 06, 2026 at 08:23:04AM -0700, Darrick J. Wong wrote:

Thank you for reviewing this patch as well.

> Same question as the previous patch -- does xfs_da3_node_create actually
> zero out the pad field?

Yes, xfs_da3_node_create already does
memset(hdr3, 0, sizeof(struct xfs_da3_node_hdr)) which covers __pad32.

> and same comment about how you can only set xchk_da_set_preen if old
> kernels were ok with nonzero __pad32.
> 
> --D
> 

Understood. I'll switch to xchk_da_set_preen as well.

I'll send a v2 with this change.

Thanks,
Yuto



Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284

Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705