Re: [PATCH 1/2] coresight: etm4x: fix inconsistencies with sysfs configration

[Yeoreum Yun]

Hi Suzuki,

[...]

> >    - config, which stores the settings configured via sysfs.
>
> While we are at it, should we stop using the drvdata->config for the
> "capabilities" for the ETM (e.g., TRCSSCSRn in ss_status ?) Instead
> we could save it in "drvdata->ss_status". This keeps everything
> separated:

Hmm, if we think the drvdata->ss_status as "capabilities",
I think we doesn't need to save/restore ss_status in
etm4_disable_hw()/etm4_enable_hw() since cpu idle doesn't use both
and other bits (STATUS and PENDING) should be cleared when new session
is started regardless of perf or sysfs mode.

Am I missing something?

--
Sincerely,
Yeoreum Yun