Re: [PATCH 2/2] iio: dac: mcp47feb02: add MCP48FEB02 SPI driver to MCP47FEB02 I2C driver

[Andy Shevchenko]

On Sat, Apr 04, 2026 at 08:49:55AM -0500, David Lechner wrote:
> On 4/3/26 5:50 AM, Ariana Lazar wrote:
> > This is the iio driver for Microchip MCP48FxBy1/2/4/8 series of
> > buffered voltage output Digital-to-Analog Converters with nonvolatile or
> > volatile memory on top of MCP47FEB02. The families support up to 8
> > output channels and have 8-bit, 10-bit or 12-bit resolution.
> > 
> > The MCP47FEB02 driver was split into three modules: mcp47feb02-core.c,
> > mcp47feb02-i2c.c and mcp47feb02-spi.c in order to support both DAC families
> > - I2C (MCP47F(E/V)BXX) and SPI (MCP48F(E/V)BXX).

...

> > Fixes: bf394cc80369 ("iio: dac: adding support for Microchip MCP47FEB02")

Really?! (See also below)

...

> >  obj-$(CONFIG_MCP47FEB02) += mcp47feb02.o
> 
> Shouldn't we be removing this old file?

> The patch series would be eaiser to understand if it was split into
> one commit to split the existing driver into two files and then
> another commit to add support for the new parts.

Exactly! We do not expect to have this huge contribution as a fix, it just
a normal development and hence the existing code needs to be refactored.

> > +mcp47feb02-objs := mcp47feb02-core.o
> > +obj-$(CONFIG_MCP47FEB02_I2C) += mcp47feb02-i2c.o
> > +obj-$(CONFIG_MCP47FEB02_SPI) += mcp47feb02-spi.o

-- 
With Best Regards,
Andy Shevchenko