Re: [PATCH v2] HID: sony: add support for more instruments

[Rosalie]

Hello,

I've sent 'HID: sony: fix incorrect Squier name and remove non-existent 
device', though I will mention you didn't apply 'HID: quirks: update 
hid-sony supported devices' cleanly because it duplicated the vendor and 
device ID defines in hid-ids.h for the Wii instruments so it will not 
compile, I'd advise you apply the patches in the following order to 
prevent issues:

1) v1 of 'HID: sony: add support for more instruments'
2) 'HID: sony: fix incorrect Squier name and remove non-existent device'
3) v2 of 'HID: quirks: update hid-sony supported devices' but without 
changing hid-ids.h
4) v2 of 'HID: sony: fix style issues' (if you want this patch to be 
included that is)

alternatively you could also do:

1) v2 of 'HID: sony: add support for more instruments'
2) v2 of 'HID: quirks: update hid-sony supported devices'
3) v2 of 'HID: sony: fix style issues'

I hope this doesn't cause too much hassle,
Rosalie

On 4/8/26 22:41, Jiri Kosina wrote:
> On Tue, 7 Apr 2026, Rosalie Wanders wrote:
>
> > This patch adds support for the following instruments:
> >
> > * Rock Band 1/2/3 Wii/PS3 instruments
> > * Rock Band 3 PS3 Pro instruments
> > * DJ Hero Turntable
> >
> > Wii and PS3 instruments are the same besides the vendor and product ID.
> >
> > This patch also fixes the mappings for the existing Guitar Hero
> > instruments.
> >
> > Co-developed-by: Sanjay Govind <sanjay.govind9@xxxxxxxxx>
> > Signed-off-by: Sanjay Govind <sanjay.govind9@xxxxxxxxx>
> > Co-developed-by: Brenton Simpson <appsforartists@xxxxxxxxxx>
> > Signed-off-by: Brenton Simpson <appsforartists@xxxxxxxxxx>
> > Signed-off-by: Rosalie Wanders <rosalie@xxxxxxxxxxx>
> > ---
> > changes:
> > v2: correct squier device name and remove non-existent squier usb device
>
> Rosalie,
>
> as v1 is already sitting in hid.git#for-7.1/sony for some time, could you
> please send this as a followup fix instead?
>
> Thanks,