RE: [PATCH] wifi: rtw89: fix wrong pci_get_drvdata type in AER handlers
From: Ping-Ke Shih
Date: Wed Apr 08 2026 - 23:17:25 EST
Christos Longros <chris.longros@xxxxxxxxx> wrote:
> rtw89 stores an ieee80211_hw pointer via pci_set_drvdata() at probe
> time, but io_error_detected() and io_resume() retrieve it as a
> net_device pointer. This causes netif_device_detach/attach to
> operate on an ieee80211_hw struct, reading and writing at wrong
> offsets. The adjacent io_slot_reset() already does it correctly.
>
> Use ieee80211_stop_queues/wake_queues instead, consistent with
> every other queue stop/start path in the driver.
>
> Tested on RTL8852CE by calling the handlers from a test module
> before and after the fix.
Could you share the "test module" you did? I'd like to know how to
test (simulate) the io error.
>
> Signed-off-by: Christos Longros <chris.longros@xxxxxxxxx>
Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>