Re: [PATCH 02/12] arm64: dts: qcom: qcs6490-radxa-dragon-q6a: Enable UFS controller

[Xilin Wu]

On 4/8/2026 4:59 PM, Konrad Dybcio wrote:
> On 4/7/26 5:19 PM, Xilin Wu wrote:
> > Add and enable UFS related nodes for this board.
> >
> > Note that UFS Gear-4 Rate-B is unstable due to board and UFS module design
> > limitations. UFS on this board is stable when working at Gear-4 Rate-A.
> >
> > Signed-off-by: Xilin Wu <sophon@xxxxxxxxx>
> > ---
> >   .../boot/dts/qcom/qcs6490-radxa-dragon-q6a.dts     | 23 ++++++++++++++++++++++
> >   1 file changed, 23 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dts b/arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dts
> > index bb5a42b038f1..c961d3ec625f 100644
> > --- a/arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dts
> > +++ b/arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dts
> > @@ -959,6 +959,29 @@ &uart5 {
> >   	status = "okay";
> >   };
> >   
> > +&ufs_mem_hc {
> > +	reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>;
> > +	vcc-supply = <&vreg_l7b_2p96>;
> > +	vcc-max-microamp = <800000>;
> > +	vccq-supply = <&vreg_l9b_1p2>;
> > +	vccq-max-microamp = <900000>;
> > +	vccq2-supply = <&vreg_l9b_1p2>;
> > +	vccq2-max-microamp = <1300000>;
> > +
> > +	/* Gear-4 Rate-B is unstable due to board */
> > +	/* and UFS module design limitations */
>
> /* it's a bit weird to add two single-line */
> /* comments near one another for a single paragraph */

Ack. I'll change the comment to single-line in v2.
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>
> Konrad


--
Best regards,
Xilin Wu <sophon@xxxxxxxxx>