Re: [PATCH] tty: serial: pch_uart: add check for dma_alloc_coherent()

[俞朝阳]

Hi Andy,

Thank you for the review and the suggestions!

> Looks like it deserves a Fixes tag.

Agreed. I will find the original commit that introduced this issue and add the proper Fixes tag in the v2 patch. I'll send it out shortly.

> Also ideally this driver should be converted to one of 8250 cases.
> The latter has already DMA support. Note, if you are going this
> direction, I have the hardware to test.

Thank you very much for offering to test on the actual hardware! That is incredibly helpful. 

I agree that converting this driver to the 8250 framework is the right direction. Since that would be a larger refactoring effort, I think it might be best to apply this quick NULL pointer fix first so that the current driver is safe. 

After this fix is settled, I am very interested in taking a look at the 8250 conversion as a follow-up project. I might need some time to study the 8250 DMA framework, but I will definitely reach out with a patch series for you to test when I get there!

Best regards,
Zhaoyang Yu