Re: [RFC PATCH 5/5] gpio: mmio: add port-mapped read/write callbacks

From: Linus Walleij

Date: Thu Apr 09 2026 - 04:08:58 EST


Hi Jose,

thanks for your patch!

On Tue, Apr 7, 2026 at 8:49 PM Jose Javier Rodriguez Barbarin
<dev-josejavier.rodriguez@xxxxxxxxxx> wrote:

> Implement PMIO read and write callbacks for 8-, 16- and 32-bit
> register accesses using the corresponding port I/O helpers.
>
> Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@xxxxxxxxxx>

Overall this looks fine to me, but with the change that it is moved
over to using the union.

Yours,
Linus Walleij