Re: [PATCH 2/2] vfio/xe: Add a missing vfio_pci_core_release_dev()

[Niklas Schnelle]

On Wed, 2026-04-08 at 18:03 +0200, Michał Winiarski wrote:
> The driver is implementing its own .release(), which means that it needs
> to call vfio_pci_core_release_dev().
> Add the missing call.
> 
> Reported-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx>
> Closes: https://lore.kernel.org/kvm/408e262c507e8fd628a71e39904fedd99fa0ee8e.camel@xxxxxxxxxxxxx/
> Signed-off-by: Michał Winiarski <michal.winiarski@xxxxxxxxx>
> ---
>  drivers/vfio/pci/xe/main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/vfio/pci/xe/main.c b/drivers/vfio/pci/xe/main.c
> index 40ea73234dcf2..af95a011ed111 100644
> --- a/drivers/vfio/pci/xe/main.c
> +++ b/drivers/vfio/pci/xe/main.c
> @@ -528,6 +528,7 @@ static void xe_vfio_pci_release_dev(struct vfio_device *core_vdev)
>  		container_of(core_vdev, struct xe_vfio_pci_core_device, core_device.vdev);
>  
>  	xe_vfio_pci_migration_fini(xe_vdev);
> +	vfio_pci_core_release_dev(core_vdev);
>  }
>  
>  static const struct vfio_device_ops xe_vfio_pci_ops = {

Thanks for picking this up! Feel free to add my:

Reviewed-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx>