Re: [PATCH 5/5] scsi: enable async shutdown support

From: John Garry

Date: Thu Apr 09 2026 - 08:19:10 EST


On 08/04/2026 20:35, David Jeffery wrote:
Well it is not exactly like that. We have the following:

scsi_sysfs_add_sdev() -> device_enable_async_suspend(&sdev->sdev_gendev)

and

scsi_sysfs_device_initialize() ->
scsi_enable_async_suspend(&sdev->sdev_gendev) ->
device_enable_async_suspend(&sdev->sdev_gendev) when not async

Maybe similar needs to be done for this shutdown feature. AFICS, Bart,
added scsi_enable_async_suspend(), so maybe he can comment.

My inclination is to drop adding device_enable_async_shutdown into
scsi_sysfs_device_initialize. The intent is for normal scsi devices,
and I see little value in setting the flag so early to flag partially
initialized or pseudo devices.

That seems reasonable, but, again I am not so familiar with this async suspend and shutdown.

Thanks!