Re: [PATCH v2] selftests: runner: Avoid spurious warning about missing failures file

[Yohei Kojima]

On Tue, Feb 24, 2026 at 04:37:56PM +0100, Thomas Weißschuh wrote:
> When runner.sh is *not* executed via run_kselftest.sh, the variable
> $kselftest_failures_file does not exist. This triggers a harmless but
> annyoing warning from runner.sh if a test fails:
> 
> tools/testing/selftests/kselftest/runner.sh: line 50: : No such file or directory
> 
> Silence the spurious warning.
> 
> Fixes: d9e6269e3303 ("selftests/run_kselftest.sh: exit with error if tests fail")
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
> Reviewed-By: Brendan Jackman <jackmanb@xxxxxxxxxx>

Hi all,

It seems this patch hasn't been picked up yet, although it already got
reviewed by Brendan. This bug is also mentioned by a netdev maintainer
and several developers [1], so I think it would be nice to have this
patch merged.

[1]: https://lore.kernel.org/lkml/20260112135326.7ce71119@xxxxxxxxxx/

I confirmed that it still applies to 7.0-rc7. I also tested it by adding
a failing test to net and namespaces selftests, and confirmed that the
error disappeared.

Tested-by: Yohei Kojima <yk@xxxxxxxxx>

Thanks,
Yohei

> ---
> Changes in v2:
> - Rebase on v7.0-rc1
> - Pick up review tag
> - Link to v1: https://lore.kernel.org/r/20260128-kselftest-fix-failures-file-v1-1-b58072c66317@xxxxxxxxxxxxx
> ---
>  tools/testing/selftests/kselftest/runner.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh
> index 3a62039fa621..1eb935b6f790 100644
> --- a/tools/testing/selftests/kselftest/runner.sh
> +++ b/tools/testing/selftests/kselftest/runner.sh
> @@ -47,7 +47,7 @@ tap_timeout()
>  report_failure()
>  {
>  	echo "not ok $*"
> -	echo "$*" >> "$kselftest_failures_file"
> +	echo "$*" >> "${kselftest_failures_file:-/dev/null}"
>  }
>  
>  run_one()
> 
> ---
> base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
> change-id: 20260128-kselftest-fix-failures-file-8b38692c2a3c
> 
> Best regards,
> -- 
> Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
>